chore: bump go-flashduty to v0.5.7 for clearer gateway-timeout errors#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this gets fduty users
The intermediary/gateway 504 message goes from a raw JSON-parse failure to something you can actually act on. Before:
After:
This also folds in go-flashduty's monit-contract fixes (previously only reachable via a pseudo-version pinned to a side branch): tool-invoke responses correctly decode
summary/params/truncatedinstead of silently dropping them, atarget_kindsnull-leak fix, and the newLicenses/SessionReplayservices. go-flashduty'smainand itsfeat/api-review-auto-fixbranch had diverged since PR #27 — main only had the gateway-error fix, the branch only had the monit fixes — so go-flashduty#33 reunified them first. This PR picks up the result as a single proper tagged release (v0.5.7) instead of continuing on an untagged pseudo-version.Change
go.mod/go.sumonly:Verification
go build ./...— cleango test ./...— all packages pass (cmd/flashduty, internal/cli, internal/cmd/cligen, internal/cmd/skilldoc, internal/config, internal/output, internal/skilldoc, internal/timeutil, internal/update)v0.5.7is a strict superset of the previously-pinned commit (git merge-base --is-ancestorboth ways)Release step after this merges
fduty's own version is stamped entirely from the release git tag (GoReleaser
ldflags -X main.version={{.Version}}, no source constant to bump). Current latest tag isv1.3.27, so the release step is pushing tagv1.3.28on the merge commit — not done here, that's a separate step.